Skip to content

Conversation

@SuperOleg39
Copy link
Contributor

@SuperOleg39 SuperOleg39 commented Nov 24, 2025

This relates to...

#4618

Rationale

no_proxy matching logic changes related to current behaviour in curl, deno and this specification - https://about.gitlab.com/blog/we-need-to-talk-no-proxy/

Changes

  • strip leading dot, so no_proxy=.example.com is equivalent to no_proxy=example.com
  • strip leading asterisk with dot, so no_proxy=*.example.com is equivalent to no_proxy=example.com
  • drop support for substring suffix (this syntax is not specified anywhere), so no_proxy=*example is equivalent to no_proxy="" or the absence of a no_proxy variable

Breaking Changes and Deprecations

Сhanges in the current Merge Request can be considered as breaking.

Status

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (148e0ef) to head (081d2c9).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #4676       +/-   ##
=========================================
+ Coverage      0   92.85%   +92.85%     
=========================================
  Files         0      107      +107     
  Lines         0    33498    +33498     
=========================================
+ Hits          0    31103    +31103     
- Misses        0     2395     +2395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina requested a review from joyeecheung November 28, 2025 21:01
@mcollina
Copy link
Member

@joyeecheung can you review?

@mcollina mcollina added the semver-major Features or fixes that will be included in the next semver major release label Nov 28, 2025
@SuperOleg39
Copy link
Contributor Author

@joyeecheung can you review?

Just reminder 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major Features or fixes that will be included in the next semver major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants