Skip to content

Conversation

@MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Dec 31, 2025

Description

Generated by pnpm dedupe at the root.

Packages: -43
-------------------------------------------
Progress: resolved 1837, reused 1630, downloaded 0, added 3, done

Changed dependencies: https://github.com/nodejs/nodejs.org/actions/runs/20666412561/job/59339511591?pr=8499#step:3:15

Validation

All the lockfile changes here should be very carefully reviewed, and the functionality of the site should be thoroughly tested, given the number of dependencies that've changed (though of course all within semver compliance).

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Dec 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Jan 2, 2026 8:49pm

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (4a98394) to head (4f07be2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8499   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files         106      106           
  Lines        9102     9102           
  Branches      307      307           
=======================================
  Hits         6760     6760           
  Misses       2340     2340           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.75 MB
New Total Size 3.75 MB
Delta -3.88 KB (-0.10%)

Changes

➕ Added Assets (4)
Name Size
.next/static/chunks/64abd550e7ac0ca3.js 419.13 KB
.next/static/chunks/809aa53d5b37fd06.js 205.09 KB
.next/static/chunks/718e2ff5e8abb975.js 419.13 KB
.next/static/chunks/b5d845a9a413f73e.js 419.13 KB
➖ Removed Assets (4)
Name Size
.next/static/chunks/829d1de17ab54031.js 420.43 KB
.next/static/chunks/0e947be848a138cf.js 205.09 KB
.next/static/chunks/95bfa9c8ed79475e.js 420.43 KB
.next/static/chunks/01733ef3d28706f0.js 420.43 KB

@MattIPv4 MattIPv4 marked this pull request as ready for review December 31, 2025 01:00
@MattIPv4 MattIPv4 requested a review from a team as a code owner December 31, 2025 01:00
Copilot AI review requested due to automatic review settings December 31, 2025 01:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MattIPv4
Copy link
Member Author

MattIPv4 commented Dec 31, 2025

👀 @avivkeller, ideally, I'd prefer this to be merged before any of the open Dependabot PRs, just so that I don't need to essentially recreate this and have folks review the diff again?

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ovflowd
Copy link
Member

ovflowd commented Dec 31, 2025

(My SGTM is just a sign-off, I haven't tested the PR yet)

@avivkeller
Copy link
Member

LGTM, but can we wait until after the Dependabot PRs land, since it's possible they will re-introduce some duplicated dependencies?

@MattIPv4
Copy link
Member Author

Oh true, sure, I can recreate this once they're landed then.

Don't worry about reviewing this until after this is recreated then, as I imagine the diff will change.

@bmuenzenmeyer
Copy link
Contributor

@MattIPv4 can you rebase this? I did it locally too but unsure how you feel about me force pushing onto your fork/branch

@MattIPv4
Copy link
Member Author

MattIPv4 commented Jan 2, 2026

Are we planning to merge #8485 first, or is that going to stay open due to the failing OpenNext CI?

@bmuenzenmeyer
Copy link
Contributor

bmuenzenmeyer commented Jan 2, 2026

ope - missed that one in my scan - I think we should always be careful with next and open next compatibility, so I would be fine omitting it

@avivkeller avivkeller added this pull request to the merge queue Jan 2, 2026
Merged via the queue into main with commit fcfc7e2 Jan 2, 2026
13 checks passed
@avivkeller avivkeller deleted the MattIPv4/dedupe-deps branch January 2, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants