Making writeSelectLimit friendly to PDO drivers.#67
Open
prasad83 wants to merge 1 commit intonilportugues:masterfrom
Open
Making writeSelectLimit friendly to PDO drivers.#67prasad83 wants to merge 1 commit intonilportugues:masterfrom
prasad83 wants to merge 1 commit intonilportugues:masterfrom
Conversation
Executing prepared statement with values fails if limit values are not binded as integer. To overcome this making the limit friendly without adding placeholder can be very useful.
Owner
|
I'll have a look at your code and make the tests pass. Thanks for reporting 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing prepared statement with values fails if limit values are not binded as integer.
To overcome this making the limit friendly without adding placeholder can be very useful.