Set default value for Not Null Column in CRE.sql

[revsi]

No description provided.

[polybuildr]

Thanks for the PR!

This seems weird. CRE.sql has

ALTER TABLE `candidates`
  MODIFY `id` int(11) NOT NULL AUTO_INCREMENT;

and then the insert code in admin/add_candidate.php says:

$query = mysqli_prepare($DB, "INSERT INTO `candidates` (name) VALUES (?)");
mysqli_stmt_bind_param($query, 's', $_POST["candidate_name"]);

We only set name, where do the votes and n_votes come from? Does MySQL default them to 0? /cc @nisargjhaveri @hharchani

[polybuildr]

Aha, so it does default to 0. Thanks @hharchani.

@revsi, can you please update the commit message to match convention? Capital first letter, imperative tense of writing, etc.? Also, since @hharchani says it implicitly defaults to 0, maybe you can explicitly say: "Set default value of some fields in CRE.sql" or something like that?

[hharchani]

Yeah, it defaults to 0, but better to be explicit

[revsi]

I am not sure exactly. But for MySql V5.7, If strict SQL mode is enabled, an error occurs for transactional tables and the statement is rolled back in case of Not Null Column. In my case it was causing error.

[polybuildr]

Ah, I see. That's interesting. It's certainly better to be explicit then. Will merge this after the commit message change. :)

Sorry, you changed the PR title but not the commit itself. Could you please git commit --amend and update the commit message too?