MAS-121 send email with preferences V2 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 2, 2020 15:03
ediblecode
suggested changes
Jan 6, 2020
| } | ||
|
|
||
| return body.ToString(); | ||
| var dailyEmail = new DailyEmail() { Items = items.ToList() }; |
Contributor
There was a problem hiding this comment.
The email HTML generation and logic belongs in this service, hence the method name (CreateEmailBody or now CreateDailyEmailBody), it doesn't seem right to move this into a model. Also, we're doing work in #31 to have a service for async rendering a view into a string (see https://github.com/nice-digital/MAS/pull/31/files#diff-7cd77f4b3d2d846715c218e95176e069) which we'll use for creating the body of the emails, so we're not doing HTML generation inside classes.
Contributor
There was a problem hiding this comment.
So I'd pause until that's merged
|
|
||
| foreach (var group in GroupedItems) | ||
| { | ||
| string specInEvidenceType = String.Join(',', group.SelectMany(x => x.Speciality.Select(y => y.Title))); |
Contributor
There was a problem hiding this comment.
does this need de duping?
# Conflicts: # cms/models/Item.js
Use JSONLD file to look up the key for the evidence type when we're exporting items via the single API endpoint
…om/nhsevidence/MAS into MAS-121-SendEmailWithPreferences-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/MAS-121