-
Notifications
You must be signed in to change notification settings - Fork 12
Switch to karma-vite #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to karma-vite #2789
Conversation
change/@ni-nimble-components-4381b5e1-bbcc-48b4-9751-38f3ac8f2aa8.json
Outdated
Show resolved
Hide resolved
|
@jattasNI this may be a more controversial bypass as it's a nights and weekends change that adds a new dependency but it's a pretty well-scoped change that doesn't impact package output and simplifies workflows. Bypassing but can handle feedback in follow-up (though will address feedback as nights and weekends updates, somewhat adding to the controversialness a bit). |
|
I did some local verification from main today. The workflows I tried look good, can still both run headless and debug tests and it is indeed super quick now. My only feedback is not about this PR. This was the first time I tried local test run workflows since we added the retry capability. I suspect it might be slightly annoying / unnecessary to be retrying failed tests during the local debug workflow. Maybe we want a separate config for that case, or at least docs saying how to turn it off. But that's super low priority feedback, more theoretical. Can address if someone actively doing development complains. |
Pull Request
🤨 Rationale
Uses vite instead of webpack for running karma tests. Has the following benefits:
.tssource files so can avoid needing to build manually firstnimble-component:teston CI by about 10-15s (net impact on full CI is minimal due to concurrency)👩💻 Implementation
build-componentstop-level helper command🧪 Testing
Try it yourself, pretty amazing.
npm run build-componentsfdescribe), for example innimble-components(note that means source has changed since build)npm run test-chrome, should run against the latest source quickly and finishLocal run and CI
✅ Checklist