fix: resolve clippy warnings from newer Rust toolchain#74
Merged
Conversation
- Allow `mismatched_lifetime_syntaxes` in generated jaffi module. These warnings come from code generated by the jaffi build dependency, not from our source, so suppressing at the include site is appropriate. - Remove unused `JNIExt::as_string` method. - Rename `crate_type` to `crate-type` in Cargo.toml (underscore form is deprecated and will not work in edition 2024).
Contributor
Author
|
This PR is part of a stack of 5 bookmarks:
Created with jj-stack |
This was referenced Feb 18, 2026
zombiezen
approved these changes
Feb 18, 2026
Abdiramen
approved these changes
Feb 18, 2026
kmvachhani
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mismatched_lifetime_syntaxesin generated jaffi module. These warnings come from code generated by the jaffi build dependency, not from our source, so suppressing at the include site is appropriate.JNIExt::as_stringmethod.crate_typetocrate-typein Cargo.toml (underscore form is deprecated and will not work in edition 2024).