Fix mifare_cryto_postprocess_data() with MDCM_MACED + AS_LEGACY#152
Open
vinriviere wants to merge 1 commit intonfc-tools:masterfrom
Open
Fix mifare_cryto_postprocess_data() with MDCM_MACED + AS_LEGACY#152vinriviere wants to merge 1 commit intonfc-tools:masterfrom
vinriviere wants to merge 1 commit intonfc-tools:masterfrom
Conversation
This caused mifare_desfire_read_data() to fail with CRYPTO_ERROR when the communication settings are set to 1 (Plain+MAC). In this case, the received frame doesn't contain any CRC (only MAC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
mifare_desfire_read_data()fails withCRYPTO_ERRORwhen the file communication settings are set to 1 (Plain+MAC).This pull request fixes the issue.