Skip to content

Conversation

@theoholl
Copy link
Contributor

@theoholl theoholl commented Jan 2, 2026

Summary

  • Preventing ghost/duplicate tag pills by letting the tag selector emit only labels with ids and by using NcSelect’s tracked id to avoid placeholder options. However, the user has to wait for the server to create a new tag and send it back to the client before it is getting rendered in the browser. This will result in a small delay before the new tag appears.
  • Removed Vuex strict-mode warnings.

Screencasts

Before:

Screencast.Bug.mp4

After:

Screencast.Fix.mp4

…uex errors

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl theoholl changed the title Modify tag adding and removing logic to get rid of 'ghost' tags and Vuex errors [main] Fix: Adding new tag creates a 'ghost' tag Jan 2, 2026
@grnd-alt
Copy link
Member

grnd-alt commented Jan 6, 2026

Thanks a lot for your contribution 🫶
I like the approach in general, but I think making the store logic more complex might not be the right solution as the existing functions are already in place and work properly.
The function calls to them are not correct however, I think we should keep the store logic as is and fix the calls for now.
I've created a PR with a simpler fix to not push to your fork: #7508

As mentioned there we should think about adding some more logic to the card Store, or at least be more declarative about what the addLabels function requires as params.
I am open to discuss on how to improve that as a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a new tag to a card has unexpected behaviour

2 participants