Conversation
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
a5840e2 to
c5fcd67
Compare
marcelklehr
reviewed
Feb 25, 2026
| continue; | ||
| } | ||
| $value = $this->appConfig->getAppValueString($key); | ||
| $this->appConfig->setAppValueString($key, $value, lazy: true); |
Member
There was a problem hiding this comment.
Can you double check whether we need to delete the entry first for the lazy-setting to work?
Member
Author
There was a problem hiding this comment.
Works as intended for me, I don't know if there could be differences between db systems but it's just another column in the db entry so I wouldn't know why it shouldn't
marcelklehr
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.