fix(HaRP): use correct path for FRP address validation #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation that prevents protocol prefixes (http://, https://, etc.) in FRP addresses was checking the wrong path in
$params.It checked
$params['harp']['frp_address']which doesn't exist, instead of$params['deploy_config']['harp']['frp_address'].This caused the validation to always check an empty string, allowing invalid FRP addresses like "http://localhost:8782" to be saved. When deploying ExApps, this would cause FRP connection failures because the address was incorrectly parsed.
With this fix such command correctly fails:
php occ app_api:daemon:register test_harp_bug "Test HaRP Bug" "docker-install" "http" "localhost:8780" "http://localhost" --net host --harp --harp_frp_address "http://localhost:8782" --harp_shared_key "some_secure_password_123"