fix(receivers): upload

[alperozturk96]

• Tests written, or not not needed

Issue

After migrating file uploads from a foreground service to worker, the previous mechanism for notifying activities such as UploadListActivity and FileDisplayActivity via LocalBroadcastManager stopped functioning correctly.

Specifically:

Once an upload completes, the adapters (OCFileListAdapter, UploadListAdapter) are not refreshed with the updated data.
Upload start and completion events were not correctly triggered in UploadListActivity and FileDisplayActivity, preventing proper UI updates.

Changes

Ensured worker state is correctly updated in finally blocks to maintain consistency.
The adapter is now notified correctly when the FileUploadWorker finishes.
Restored previously working LocalBroadcastManager logic for notifying activities.
Removed FileUploadStarted and FileUploadCompleted worker states, as broadcasts are now used.
Broadcast receivers are registered in onStart and unregistered in onStop for proper lifecycle handling.
Added clear documentation to functions describing their purpose and expected triggers.
Adds file upload completion event for AutoUploadWorker.

Test

1. When a user manually uploads a file or files or uploads files via AutoUploadWorker, FileDisplayActivity, UploadListActivity must display an updated list after the file or files upload completion. The adapter must not be triggered excessively; it must be triggered only batch by batch.

Impact

With this change, users can see updates in real time in the file list and upload list tabs.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16317.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	257	256
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	480	479

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.