MonoCecilTempGenerator - only check path if assembly not already loaded#143
Open
K0lb3 wants to merge 2 commits intonesrak1:devfrom
Open
MonoCecilTempGenerator - only check path if assembly not already loaded#143K0lb3 wants to merge 2 commits intonesrak1:devfrom
K0lb3 wants to merge 2 commits intonesrak1:devfrom
Conversation
Author
|
I guess that alternatively it would be enough to simply remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly changes the behavior of
MonoCecilTempGenerator.GetTemplateField.So far this function checked if the given assembly string corresponds to an existing
.dllwithin the managed path.This effectively prevents adding assemblies in other ways, e.g. from memory, or from different paths.
With this PR, the function first checks if the given assembly string corresponds to an already loaded assembly, and only if not, tries to load it from a file within the managed path.