Improvements and bug fixes to MonoTempGenerator.#121
Open
AhmedAhmedEG wants to merge 1 commit intonesrak1:mainfrom
Open
Improvements and bug fixes to MonoTempGenerator.#121AhmedAhmedEG wants to merge 1 commit intonesrak1:mainfrom
AhmedAhmedEG wants to merge 1 commit intonesrak1:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Fixed a bug where types of List was getting miss-classified as a string.
2- Added null checks to prevent errors when passing unity base types to the generator.
3- Removed braces and extra lines for single-statement if conditions.
4- Removed unused import.
5- Changed the visibility of GetAssemblyWithDependencies function to public as it's very useful to be used individually, I used it to resolve base types of a given type so I can use the ClassDatabase to get AssetTypeTemplateFields from them.