Prevent nil pointer in QUIC Close method #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a nil check for q.conn in the QUIC Close method to avoid potential nil pointer dereference errors when closing a QUIC connection. Fixes the panic caused by attempting to close a connection when QUIC connection establishment fails: runtime error: invalid memory address or nil pointer dereference. Test: Manual ```shell q @quic://dns.google www.google.com ```
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds a nil check to the QUIC transport's Close method to prevent a nil pointer dereference panic when the method is called before a connection is successfully established.
- Added a nil check for
q.connbefore callingCloseWithError - Returns nil when connection is nil, avoiding panic
- Aligns with similar patterns in TLS and HTTP transports
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+153
to
+155
| if q.conn == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
The nil check for q.conn is correct and prevents a panic when Close is called before a connection is established. However, consider adding a test case that explicitly verifies Close can be called safely on a QUIC transport instance before any connection is established. This would ensure the bug fix is covered and prevent regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a nil check for q.conn in the QUIC Close method to avoid potential nil pointer dereference errors when closing a QUIC connection.
Fixes the panic caused by attempting to close a connection when QUIC connection establishment fails: runtime error: invalid memory address or nil pointer dereference.
Test: Manual
Summary by cubic
Prevented a panic in QUIC Close by making it a no-op when the connection was never established. This makes Close safe to call after failed QUIC setup.
Written for commit 7d1cba9. Summary will update automatically on new commits.