Fix segmentation fault, compiler errors, and modified file loading, saving, and deleting behavior#7
Open
thecomputerguru wants to merge 13 commits intonanoflite:masterfrom
Open
Fix segmentation fault, compiler errors, and modified file loading, saving, and deleting behavior#7thecomputerguru wants to merge 13 commits intonanoflite:masterfrom
thecomputerguru wants to merge 13 commits intonanoflite:masterfrom
Conversation
Added some #defines to allow Windows builds. Added arch/windows.
Added proper params for x64 and release builds.
Added Windows build
thecomputerguru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the current branch, I identified several issues in the code. I have addressed these and would like to merge the improvements into this branch.
Changes Made:
Fixed a segmentation fault in tokenizer.c at line 135.
Updated file loading, saving, and deleting behavior by adding a check for .bas extension in the filename. If the filename already has a .bas extension it will not be appended to the filename, but if it doesn't exist, it will be appended.
Removed duplicate nanosleep code that was causing compiler errors.
Modified _dummy declaration from char *_dummy = 0; to static char _dummy = 0; to resolve compiler errors.
These changes improve code stability/program functionality and eliminate compilation issues.