Composer

[unhandyandy]

First attempt to add support for the composer tag. Only supports mp3 and ogg vorbiis formats.

[multani]

I'm not against merging this, but you based your work on code which is 3 years old.
Can you rebase it against my master branch and update your pull request? I'll have a look then.

Thanks!

[multani]

I had a very quick look, here are the things that you should look into:

• Sonata now uses Python 3, Gtk 3 and GtkBuilder (to build the UI)
• mpdh.get(songinfo, XXX) has been removed. You should now directly access the property of songinfo as in songinfo.XXX
• there are lot of print statements left over (commented, but they would need to be removed).
  • Sonata now uses the Python's logging module, you can use it if there are interesting things to log
• you have several try/except not bound to any special exceptions. I know Sonata has many, but I'm trying my best to remove them and not add new. Although, they are handy sometimes, the code within the try/except should be as minimal as possible and comments on what can possibly and why are generally really useful if the code need to be refactored later.
• don't change constants values, add yours to the end of the list.

I'll have a look more in details when you resubmit your branch.

Thanks again!

[unhandyandy]

Oooops...

I cloned it from git://git.berlios.de/sonata, there was no indication
there that you've moved to github. Of course I should have found it odd
that have been no modifications since 2009.

It will take me months to recover from this shock, but maybe I can redo
everything in the Spring...

On 01/10/2014 09:54 PM, Jonathan Ballet wrote:

I'm not against merging this, but you based your work on code which is
3 years old.
Can you rebase it against my master branch and update your pull
request? I'll have a look then.

Thanks!

—
Reply to this email directly or view it on GitHub
#58 (comment).

[multani]

I don't have access to http://sonata.berlios.de/ but I guess I will try
to contact the current maintainers (which are taking care of
http://codingteam.net/project/sonata) to see if I have have control of
the website.

Sorry about the confusion :/

[DolphinStKom]

If this will be realized I will need at least information of all the dependencies order to properly organize a new ebuild for Gentoo and make this functional as the key for installation

[DolphinStKom]

and I can help test new functional if this will be realized for example in some sort of branch

[multani]

I don't think there's any new dependency change, so there should not be any reason to update the ebuild.

Stanislav notifications@github.com wrote:

If this will be realized I will need at least information of all the dependencies order to properly organize a new ebuild for Gentoo and make this functional as the key for installation

—
Reply to this email directly or view it on GitHub.