Draft
Conversation
…d Money Transfer domain models
georgolden
reviewed
Dec 21, 2022
Collaborator
georgolden
left a comment
georgolden
left a comment
There was a problem hiding this comment.
Overall:
- There is a job that can be handled independently from other parts of the application - creating instances. Creating instances and DI are jobs that are better kept in one place. Right now it is widespread.
- Configs are only needed during instanciating
- Using
index.jsfiles. It makes things very unclear. If you want to have a collection of routes or a collection of services better to useservices.jsorroutes.jsinstead. And it is better to not handle instances here. - Closure is nice, but try to move as much code as possible out of closure to make it purer. It is generally OK to use closures instead of classes.
georgolden
approved these changes
Dec 26, 2022
Comment on lines
+12
to
+26
| server: { | ||
| host: process.env.HOST || '0.0.0.0', | ||
| port: Number(process.env.PORT) || 9000, | ||
| instance: {}, | ||
| cors: { | ||
| origin: '*', | ||
| methods: '*', | ||
| allowedHeaders: '*', | ||
| credentials: true, | ||
| }, | ||
| swagger: { | ||
| title: 'Test', | ||
| version: '1.0.0', | ||
| routePrefix: '/docs', | ||
| serverUrl: process.env.SERVER_URL || 'http://localhost:9000', |
Collaborator
There was a problem hiding this comment.
I suggest moving cors and swagger as separate configs. Better to keep tiny configs
…draw and transfer operations
…updated bus to support session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.