cmake: fix build with ninja generator #807
Conversation
| DOWNLOAD_COMMAND "" | ||
| CONFIGURE_COMMAND "" | ||
| BUILD_COMMAND cargo build --features=gecko-in-tree COMMAND cargo build --release --features=gecko-in-tree | ||
| BUILD_BYPRODUCTS "${PROJECT_SOURCE_DIR}/src/cubeb-pulse-rs/target/$<IF:$<CONFIG:Debug>,debug,release>/libcubeb_pulse.a" |
There was a problem hiding this comment.
drive-by: will this work if libcubeb-pulse is cross-compiled for a different architecture?
There was a problem hiding this comment.
(also, thanks for the patch!)
There was a problem hiding this comment.
drive-by: will this work if libcubeb-pulse is cross-compiled for a different architecture?
Why not? It's the same file that is referenced by the target_link_libraries call below.
There was a problem hiding this comment.
Ah right, thanks for pointing that out. I think that's broken, too (cross-compiled rust would live in target/arch-triple/{debug,release}, if i recall correctly), so this won't make it broken in any new ways.
|
cc @kinetiknz |
JoshuaVandaele
left a comment
JoshuaVandaele
left a comment
There was a problem hiding this comment.
Tested on Linux, indeed fixed using the Ninja generator.
3 participants
Fix this error when using
Ninjagenerator andRustbackendcmake -G Ninja -D BUILD_RUST_LIBS=ON ...Because of this and that.