feat(visual-tests): replace percy with vizzly ember sdk#186
Open
nicksteffens wants to merge 4 commits intomainfrom
Open
feat(visual-tests): replace percy with vizzly ember sdk#186nicksteffens wants to merge 4 commits intomainfrom
nicksteffens wants to merge 4 commits intomainfrom
Conversation
- Bump volta node pin 14 → 22 (Vizzly hard requirement) - Install @vizzly-testing/cli and @vizzly-testing/ember - Wrap testem.js with configure() from @vizzly-testing/ember - Add vizzly-snapshot.js helper as drop-in for percy-snapshot.js - Migrate all 12 integration test files to import vizzly-snapshot - Add vizzly:test and vizzly:tdd npm scripts - Update CI: swap PERCY_TOKEN → VIZZLY_TOKEN, install Playwright Chromium Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Downgrade volta node pin 22 → 20 (vizzly supports node 20+) - Replace @mozaic-ds/postcss-sass (bundles source-map@0.7 WASM) with @csstools/postcss-sass@5.1.1 (no nested source-map, postcss 8 compatible) - Upgrade ember-auto-import 1.x → 2.x to support package.json exports field required by @vizzly-testing/ember/test-support - Add webpack@5 devDependency (required peer dep of ember-auto-import@2) - Add .vizzly/ to .gitignore (local TDD baseline data) All 85 tests pass, 43 visual snapshots captured in local TDD mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prototype spike (sc-189157) replacing Percy with Vizzly for visual regression testing in the Fluid Ember design system.
14.17.1→22.14.0(Vizzly hard requirement)@vizzly-testing/cliand@vizzly-testing/embertestem.jswithconfigure()from@vizzly-testing/ember— Vizzly hooks into Testem and uses Playwright under the hood for screenshot capturetests/helpers/vizzly-snapshot.jsas a drop-in forpercy-snapshot.js(same API, same call sites, just callsvizzlyScreenshotinternally)PERCY_TOKEN→VIZZLY_TOKEN, runsvizzly run "ember exam"instead ofpercy exec -- ember examKnown blocker: ember-cli 3.28 incompatible with Node 22
The
testjob crashes with exit code 134 (SIGABRT) becauseember-cli 3.28uses theesmpackage which calls a Node.js internal API (InternalModuleStat) that was changed in Node 22. This is a hard incompatibility — not a Vizzly issue.Vizzly requires Node ≥ 22. ember-cli 3.28 only supports Node 12/14/16.
To unblock this migration, Fluid needs to upgrade to a version of ember-cli that supports Node 22 (ember-cli 4.x+, which requires Ember 4+). That is a separate, significant upgrade track.
The Vizzly integration code in this PR is correct — the pattern will work once the ember-cli upgrade is complete.
Test plan
VIZZLY_TOKENsecret tomovableink/fluidGitHub repo settingsyarn vizzly:tddlocally to confirm screenshots appear in local TDD dashboard🤖 Generated with Claude Code