fix: matching for models with a composite primary key#1264
Open
monktastic wants to merge 1 commit intomorintd:masterfrom
Open
fix: matching for models with a composite primary key#1264monktastic wants to merge 1 commit intomorintd:masterfrom
monktastic wants to merge 1 commit intomorintd:masterfrom
Conversation
|
I can confirm this fixes the issue for me as well. |
Author
|
Replicated this PR via |
|
@morintd We're unable to upgrade prismock without this fix. Please take a look. I can help move this along if any changes are made. |
|
I was about to put up the same PR then found this one. Is this repo still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #1263
Models with composite primary keys had their match functionality broken in 1.35.