Don't break paths on space while fixing for rvm#476
Open
TheGrayFrost wants to merge 1 commit intomoovweb:masterfrom
Open
Don't break paths on space while fixing for rvm#476TheGrayFrost wants to merge 1 commit intomoovweb:masterfrom
TheGrayFrost wants to merge 1 commit intomoovweb:masterfrom
Conversation
TheGrayFrost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running GVM in my WSL installation, which has many paths contains space like:
/mnt/c/Program Files/Microsoft SQL Server/Client SDK..
When this script would run on startup, it would mess up these paths as it splits on both ":" and " "
In general, space is not a special char in bash paths, so we should not split on it. Seems to be a typo.