Fix release notes diff in github release actions#1882
Open
atandon2024 wants to merge 1 commit intomongodb:mainfrom
Open
Fix release notes diff in github release actions#1882atandon2024 wants to merge 1 commit intomongodb:mainfrom
atandon2024 wants to merge 1 commit intomongodb:mainfrom
Conversation
rozza
reviewed
Feb 9, 2026
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
One question about fetch depth.
| with: | ||
| app_id: ${{ vars.APP_ID }} | ||
| private_key: ${{ secrets.APP_PRIVATE_KEY }} | ||
| fetch-depth: 0 |
Member
There was a problem hiding this comment.
What does this do?
I think fetch-depth: 0 fetches all history for all branches and tags. But is it just for the mongodb-labs/drivers-github-tools/secure-checkout or is it for the java driver repo itself?
Collaborator
Author
There was a problem hiding this comment.
@rozza yes fetch-depth 0 fetches all branches and tags.
Per the GitHub Actions documentation (https://docs.github.com/en/actions/tutorials/create-an-example-workflow), drivers-github-tools is only pulled internally to run the action itself. The checkout operates on github.ref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GitHub Actions release notes generation - Corrects an issue where draft release notes included commits from earlier releases due to an incorrect comparison range.
Needs to be tested by triggering Github Actions manually before merging.