refactor(dependencies): use devtools & relocated utils, drop pymake#1670
Merged
christianlangevin merged 2 commits intomodflowpy:developfrom Dec 24, 2022
Merged
refactor(dependencies): use devtools & relocated utils, drop pymake#1670christianlangevin merged 2 commits intomodflowpy:developfrom
christianlangevin merged 2 commits intomodflowpy:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1670 +/- ##
=========================================
- Coverage 71.4% 71.4% -0.1%
=========================================
Files 253 253
Lines 55884 55881 -3
=========================================
- Hits 39946 39940 -6
- Misses 15938 15941 +3
|
0ecd1de to
7c044a5
Compare
7c044a5 to
de18dd9
Compare
christianlangevin
approved these changes
Dec 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
pymakein autotests with comparison/etc functions newly relocated frompymakeand utilities now inmodflow-devtools. Allows code unrelated to building programs to be removed frompymake. Moved from feat(utils): move channel flow utilities from modflow6 #1668Adapt
regression/test_modflow.py::test_mf2005fhbto the new behavior ofget_entries_from_namefile()inflopy/utils/mfreadnam.py, recently relocated from pymake. The function used to return a single-entry list with a tuple ofNones if no entries are found, but now just returns an empty list in that caseRemove
pymake-specific print statements from recently relocated utilities