fix: fixing a bug for the Master algorithm where connections could be…#400
Open
PeterMeisrimelModelon wants to merge 1 commit intomasterfrom
Open
fix: fixing a bug for the Master algorithm where connections could be…#400PeterMeisrimelModelon wants to merge 1 commit intomasterfrom
PeterMeisrimelModelon wants to merge 1 commit intomasterfrom
Conversation
… initialized incorrectly when FMUs were initialized separately and using step_size_downsampling
efredriksson-modelon
approved these changes
Mar 17, 2026
Collaborator
efredriksson-modelon
left a comment
efredriksson-modelon
left a comment
There was a problem hiding this comment.
Nice job hunting this down!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… initialized incorrectly when FMUs were initialized separately and using step_size_downsampling
The issue is that when using step_size_downsampling we only update the internally stored update values at the corresponding downsampling rates. If using non-zero downsampling rates and manually initialize the FMUs, the values could effectively be taken from
np.empty().