fix: return 400 instead of 500 when body read fails in stateless mode#817
Open
roncodingenthusiast wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
jba
reviewed
Feb 24, 2026
Contributor
jba
left a comment
There was a problem hiding this comment.
This seems reasonable. Will let Maciej approve.
Co-authored-by: Cursor <cursoragent@cursor.com> Made-with: Cursor
d541ba0 to
17423c1
Compare
maciej-kisiel
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
http.StatusInternalServerErrortohttp.StatusBadRequestwhenio.ReadAll(req.Body)fails during stateless mode initialization in the streamable HTTP handler.Fixes #816
Rationale
Body read failures are client-side errors (disconnection, timeout, incomplete request), not server errors. Returning 500 is misleading and causes unnecessary alert fatigue for users monitoring their MCP servers.
This makes the behavior consistent with
servePOSTwhich already returns 400 for the same error condition.Testing