Fix Extensions not being copied to ServerCapabilities during initialization#1399
Merged
stephentoub merged 6 commits intomainfrom Feb 28, 2026
Merged
Fix Extensions not being copied to ServerCapabilities during initialization#1399stephentoub merged 6 commits intomainfrom
stephentoub merged 6 commits intomainfrom
Conversation
In McpServerImpl.ConfigureExperimental, the Extensions property from the options was not being copied to the server's ServerCapabilities. This caused Extensions to be missing from the initialize response. Also added: - Test for Extensions in initialize response - Test for Experimental in initialize response - Reflection-based test to catch future missing capability copies Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deserialization of extensions into server capabilities
Fix Extensions not being copied to ServerCapabilities during initialization
Feb 27, 2026
stephentoub
reviewed
Feb 27, 2026
stephentoub
reviewed
Feb 27, 2026
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
…ory.Build.props) Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
halter73
reviewed
Feb 27, 2026
…d remove redundant = new() initializer Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
halter73
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigureExperimentalinMcpServerImpl.csto copyExtensionsfrom options toServerCapabilitiesExtensionsproperty instead of internalExtensionsCore#pragma warning disable MCPEXP001in test (already suppressed intests/Directory.Build.props)ConfigureExperimental→ConfigureExperimentalAndExtensions= new()fromServerCapabilitiesproperty (already set in ctor)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.