Link with prebuilt OpenBLAS and fix shared libs build on Windows #3036
+33
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3031.
Close #3020.
This PR links MLX with the prebuilt dynamic library of OpenBLAS on Windows instead of building it from source code, which can save a lot of build time. (Note that we can not do static-linking, check the comments for more.)
Which then requires changing the locations where libraries and executables are generated, as Windows requires the DLL and EXE files be in the same directory (as there is no equivalent of RPATH on Windows):
tests/test.exe)binsub-dir)Note that the locations are only changed for Windows, and only when MLX is the top project, for projects that include MLX as a third party library there is nothing changed.
/cc @dhiltgen