Refactor GetManifestForRegisteredProvider to use XmlWriter #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetManifestForRegisteredProvidermethod hand-crafted XML through string concatenation and manual escaping. This refactoring replaces it withXmlWriterwhile maintaining byte-for-byte compatibility with the original output.Changes
Core refactoring:
StringWriterwithXmlWriter.Create()for XML generationEventData,TemplateData,MapData) to separate data collection from serializationGetManifestForRegisteredProvider_Legacy()for validationCompatibility fixes:
XmlUtilities.XmlEscape()to all stringId values before HashSet insertion to match legacy deduplication behavior>character inside task elements with opcodes usingwriter.WriteString(">")Testing:
GetManifestForRegisteredProvider_NewAndLegacyImplementationsProduceSameOutput()test with XML normalization to verify structural equivalenceExample
Before:
After:
Notes
The legacy code writes
manifest.WriteLine(">")on line 1083, creating a text node containing>inside task elements. This technically malformed XML is replicated viawriter.WriteString(">")to maintain output compatibility.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.