console_relay: add relay_console_pipe for server-side pipe relay#3044
Merged
benhillis merged 1 commit intomicrosoft:mainfrom Mar 18, 2026
Merged
Conversation
Extract the stdio relay logic into a shared relay_stdio helper, and add a new relay_console_pipe entry point that accepts an already-connected pipe handle. This is useful when the caller is the named pipe server (e.g., HCS sample) rather than the client. relay_console now delegates to relay_stdio as well, keeping the relay logic in one place.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors console relay functionality in support/console_relay by extracting the shared stdio relay logic into a helper (relay_stdio) and adding a Windows-only entry point (relay_console_pipe) for relaying over an already-connected named pipe (server-side scenarios).
Changes:
- Extract common stdin/stdout relay logic into
relay_stdio. - Update
relay_consoleto delegate torelay_stdio. - Add
relay_console_pipe(Windows-only) to relay using an already-connected pipe handle.
You can also share your feedback on Copilot code review. Take the survey.
Member
Author
|
copilot review comments are pre-existing behavior, should address these as follow-ups if needed |
jstarks
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the stdio relay logic into a shared relay_stdio helper, and add a new relay_console_pipe entry point that accepts an already-connected pipe handle. This is useful when the caller is the named pipe server (e.g., HCS sample) rather than the client.
relay_console now delegates to relay_stdio as well, keeping the relay logic in one place.