virt_mshv: Wire up SignalMsi implementation#3038
Merged
jstarks merged 2 commits intomicrosoft:mainfrom Mar 18, 2026
Merged
Conversation
Co-authored-by: GitHub Copilot Signed-off-by: Aurélien Bombo <abombo@microsoft.com>
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
c4120ee to
dc835f0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MSI interrupt delivery for the MSHV backend by wiring up the SignalMsi interface, so PCIe devices no longer connect to a disconnected MSI target that drops interrupts.
Changes:
- Implement
virt::Partition::as_signal_msi()forMshvPartitionto return an MSI signaling target. - Implement
pci_core::msi::SignalMsiforMshvPartitionInner, delegating to the existingrequest_msi()path. - Add the
pci_coreworkspace dependency tovirt_mshv.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
vmm_core/virt_mshv/src/lib.rs |
Exposes an MSI signaling target for MSHV and implements SignalMsi by forwarding to request_msi(). |
vmm_core/virt_mshv/Cargo.toml |
Adds pci_core dependency needed for the SignalMsi trait. |
Cargo.lock |
Lockfile update reflecting the new pci_core dependency. |
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: abombo@microsoft.com <abombo@microsoft.com>
smalis-msft
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MSHV backend did not override
as_signal_msi(), so the default returnedNoneand left PCIe MSI connections wired to a disconnected target that silently dropped all interrupts. This caused PCIe devices to hang after probe (see below). Fixed this by implementingSignalMsiforMshvPartitionInner, delegating to the existingrequest_msi().Co-authored-by: GitHub Copilot