Update docstrings for GemNetTDenoiser and dataset methods#134
Open
luisbro wants to merge 2 commits intomicrosoft:mainfrom
Open
Update docstrings for GemNetTDenoiser and dataset methods#134luisbro wants to merge 2 commits intomicrosoft:mainfrom
luisbro wants to merge 2 commits intomicrosoft:mainfrom
Conversation
luisbro
commented
Apr 11, 2025
Comment on lines
+196
to
+197
| property_embeddings_adapt (torch.nn.ModuleDict, optional): Property embeddings used in | ||
| a conditioned model, fine-tuned from a base model. Unused here. |
Author
There was a problem hiding this comment.
To me it seemed that property_embeddings_adapt is unused here and only used in the child class GemNetTAdapter, which handles the fine tuning, so I added the hint "unused here". It could probably be removed, but then one might also want to remove it from some yaml files and I wasn't too sure about it, so it just stuck to the hint instead of trying to remove it. Possibly the consistency to the other classes might be desireable.
Author
@microsoft-github-policy-service agree |
a120367 to
655a68e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the docstrings of a few methods to match their input arguments.