This repository was archived by the owner on May 20, 2021. It is now read-only.
Open
Conversation
mmoskal
suggested changes
Jul 7, 2020
Contributor
mmoskal
left a comment
mmoskal
left a comment
There was a problem hiding this comment.
The service should be in pxt-jacdac-services not here
rgbledclient.ts
Outdated
| //% weight=2 blockGap=8 | ||
| //% group="RGBLED" | ||
| setColor(colorCode: number): void { | ||
| let buf = Buffer.create(4); |
Contributor
There was a problem hiding this comment.
maybe send 3 bytes, so it won't get confused if it's extended to 2 pixels?
Member
Author
There was a problem hiding this comment.
Okie dokie. Does the jacdac layer add the correct padding as required by the spec?
Co-authored-by: Michał Moskal <michal@moskal.me>
I expect pxt-jacdac-services will need bumping
Member
Author
|
Gonna need to bump pxt-jacdac-services for these changes to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mmoskal @pelikhan Could you help me integrate this into pxt-jacdac-services? I'd also love for you to point out anything I've done wrong in my implementation!