Added string.replace() and .replaceAll()#698
Conversation
|
@microsoft-github-policy-service agree |
pelikhan
left a comment
There was a problem hiding this comment.
Could you add a test with replacing a string with multiple characters?
Added, also found a bug where replaceAll could loop infinitely so fixed that as well. |
|
what if searchvalue equals replace value? |
|
i believe it shouldn't be an issue, that was part of the bug with replaceAll because if replaceValue contained searchValue it would just match against it forever. |
|
What if you replace "" with ""? |
finishes 1 task off of #683