-
Notifications
You must be signed in to change notification settings - Fork 1.1k
.NET: Update GitHub.Copilot.SDK to 0.1.23 and copy new session config prope… #3788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rties - Bump GitHub.Copilot.SDK from 0.1.18 to 0.1.23 - Add new SessionConfig properties: ReasoningEffort, Hooks, OnUserInputRequest, WorkingDirectory, ConfigDir, InfiniteSessions - Add missing ResumeSessionConfig properties: Model, SystemMessage, AvailableTools, ExcludedTools, ReasoningEffort, Hooks, OnUserInputRequest, WorkingDirectory, ConfigDir, InfiniteSessions - Fix UserMessageDataAttachmentsItem -> UserMessageDataAttachmentsItemFile for new polymorphic attachment API - Add unit tests for new session config properties
|
#3786 - Fixing the issue I shared earlier today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the .NET GitHub Copilot integration to align with newer GitHub.Copilot.SDK session configuration capabilities and its updated attachment model.
Changes:
- Bump
GitHub.Copilot.SDKNuGet dependency from0.1.18to0.1.23. - Plumb newly added
SessionConfig/ResumeSessionConfigproperties throughGitHubCopilotAgentwhen creating/resuming sessions. - Update data attachment creation to use the new polymorphic attachment type, and add unit tests around session config construction.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dotnet/Directory.Packages.props | Updates GitHub.Copilot.SDK package version to 0.1.23. |
| dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs | Copies new session/resume config fields and updates attachment creation type. |
| dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs | Adds constructor-focused tests for new session config properties. |
dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs
Show resolved
Hide resolved
- Extract CopySessionConfig/CopyResumeSessionConfig as internal static helpers to eliminate duplicated mapping logic between RunCoreStreamingAsync and CreateResumeConfig (addresses reviewer comment on drift risk) - Add InternalsVisibleTo for unit test project - Replace shallow constructor tests with comprehensive property-verification tests that validate every config property is correctly copied, including OnUserInputRequest (addresses reviewer comments on test coverage)
Changes
Motivation and Context
Description
Contribution Checklist