Open
Conversation
vishiy
reviewed
Apr 15, 2019
ci_feature/setup.sh
Outdated
| #wget https://github.com/Microsoft/Docker-Provider/releases/download/hotfix-01292019/docker-cimprov-3.0.0-8.universal.x86_64.sh | ||
|
|
||
| wget "https://dockerprovider.blob.core.windows.net/releases/download/4.0.0-0/docker-cimprov-4.0.0-0.universal.x86_64.sh" | ||
| wget https://diliprstorage.blob.core.windows.net/mycontainer/docker-cimprov-3.0.0-5.universal.x86_64.sh |
Member
There was a problem hiding this comment.
can we create a release in github (against health branch) and put the bits there ? please dont ship thru private channels...
vishiy
reviewed
Apr 15, 2019
ci_feature_prod/setup.sh
Outdated
| touch /etc/.omi_disable_service_control | ||
|
|
||
| wget "https://github.com/Microsoft/Docker-Provider/releases/download/4.0.0-0/docker-cimprov-4.0.0-0.universal.x86_64.sh" | ||
| wget https://diliprstorage.blob.core.windows.net/mycontainer/docker-cimprov-3.0.0-5.universal.x86_64.sh |
Member
There was a problem hiding this comment.
can we change the version from 3.0.0.5 (which is last released version) to a different version please ?
…nto dilipr/kubeHealth
1. exit if cluster is already onboarded 2. exit if cluster is already opted out of monitoring, but omsagent still runs
…nto dilipr/kubeHealth
vishiy
reviewed
Aug 5, 2019
| kind: Service | ||
| apiVersion: v1 | ||
| metadata: | ||
| name: replicaset-service |
Member
There was a problem hiding this comment.
A more 'specific' name - so when anyone lists the servcies in the cluster, they can make out that this is for azure monitor containers.
vishiy
reviewed
Aug 5, 2019
| # value: "VALUE_AKS_RESOURCE_ID_VALUE" | ||
| #- name: AKS_REGION | ||
| # value: "VALUE_AKS_RESOURCE_REGION_VALUE" | ||
| - name: AKS_RESOURCE_ID |
vishiy
reviewed
Aug 5, 2019
| value: "my_acs_cluster_name" | ||
| #- name: ACS_RESOURCE_NAME | ||
| # value: "my_acs_cluster_name" | ||
| - name: DISABLE_KUBE_SYSTEM_LOG_COLLECTION |
Member
There was a problem hiding this comment.
this has been removed in the last release. This looks like a bad merge...
vishiy
reviewed
Aug 5, 2019
| parameters: | ||
| skuName: Standard_LRS | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 |
Member
There was a problem hiding this comment.
Hope all these things go away as we move away from azure file auto provisioning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.