Fix AG_E_LAYOUT_CYCLE crash in widgets due to MinHeight exceeding Max Height#9340
Open
pranav-gupta-msft wants to merge 1 commit intomainfrom
Open
Fix AG_E_LAYOUT_CYCLE crash in widgets due to MinHeight exceeding Max Height#9340pranav-gupta-msft wants to merge 1 commit intomainfrom
pranav-gupta-msft wants to merge 1 commit intomainfrom
Conversation
…Height When rendering adaptive cards in widgets with fixed dimensions, setting a MinHeight value greater than the MaxHeight constraint caused XAML to throw AG_E_LAYOUT_CYCLE (0x802B0014), resulting in widget crashes. Changes: - XamlBuilder.cpp: Clamp card MinHeight to not exceed fixed height when fixedDimensions are set, preventing impossible layout constraints - AdaptiveCarouselRenderer.cpp: Apply same constraint validation for carousel elements with HeightInPixels property The fix ensures MinHeight never exceeds MaxHeight by automatically clamping the value to the maximum allowed height, allowing cards to render successfully without layout cycle errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering adaptive cards in widgets with fixed dimensions, setting a MinHeight value greater than the MaxHeight constraint caused XAML to throw AG_E_LAYOUT_CYCLE (0x802B0014), resulting in widget crashes.
Changes:
The fix ensures MinHeight never exceeds MaxHeight by automatically clamping the value to the maximum allowed height, allowing cards to render successfully without layout cycle errors.