Skip to content

Add query_string option to append params#101

Open
keslert wants to merge 2 commits intomgwidmann:masterfrom
keslert:query-param
Open

Add query_string option to append params#101
keslert wants to merge 2 commits intomgwidmann:masterfrom
keslert:query-param

Conversation

@keslert
Copy link

@keslert keslert commented Aug 13, 2020

Forked from #91. Solves #89 and #70.

@nkezhaya
Copy link

@keslert @minibikini This has a pretty critical bug in it. On line 349 you're calling |> String.replace(~r/&?page=\d/, ""), which doesn't account for page numbers with multiple digits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants