Skip to content

Conversation

@biblicalph
Copy link
Contributor

  1. Avoid creating a full clone of the input event just for error recovery, instead passing back the (already-owned) event.
  2. Fix use of .unwrap() for the log schema message field. In practice this is always set anyway.
  3. Avoid wrapping and truncation for u32 casting.

Ref: LOG-22997

Summary

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@mdeltito mdeltito force-pushed the biblicalph/LOG-22997-tweak branch from adec3c3 to 068f9ce Compare January 28, 2026 15:54
1. Avoid creating a full clone of the input event
   just for error recovery, instead passing back the
   (already-owned) event.
2. Fix use of `.unwrap()` for the log schema message
   field. In practice this is always set anyway.
3. Avoid wrapping and truncation for `u32` casting.

Ref: LOG-22997
@mdeltito mdeltito force-pushed the biblicalph/LOG-22997-tweak branch from 068f9ce to 1cc42db Compare January 28, 2026 16:06
@biblicalph biblicalph changed the base branch from master to biblicalph/LOG-23027 January 28, 2026 16:53
@mdeltito mdeltito merged commit c6ead81 into biblicalph/LOG-23027 Jan 28, 2026
0 of 2 checks passed
@mdeltito mdeltito deleted the biblicalph/LOG-22997-tweak branch January 28, 2026 16:56
@logdnabot
Copy link
Contributor

🎉 This PR is included in version 6.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants