Open
Conversation
Gerrit91
force-pushed
the
finalizer-handling
branch
from
d211b13 to
4fa9e05
Compare
Contributor
Author
|
For some reason the implementation introduces a race condition resulting in concurrent modification errors between monitor and set controller in the integration tests. I do not understand why this happens, so integration tests fail now and then. I will try to find the cause... |
Contributor
Author
|
I added a retry, which seems to stabilize tests. |
Gerrit91
force-pushed
the
finalizer-handling
branch
from
28da5d3 to
f3c2884
Compare
Gerrit91
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For firewall migration we need to delete the FCM resources inside the seed's shoot namespace: metal-stack/gardener-extension-provider-metal#308
However, it is not possible to delete any of the resources bypassing the controller's deletion flow because we are automatically adding a finalizer on reconcile.
This PR drops adding the finalizer, which allows to patch out the finalizers and then delete the resource, preventing the FCM to do any further actions from the deletion flow.
Additionally, it adds an annotation to the firewall monitor that contains the seed api URL. This way, the firewall-controller can attempt to update its seed client in case the endpoint has changed due to a shoot migration.