Product Menu aligning. + fixed paddingScale warning#31
Merged
eugenebelov merged 12 commits intomasterfrom Dec 15, 2025
Merged
Conversation
eugenebelov
reviewed
Dec 11, 2025
src/lib/components/navigation/cspr-products-menu/products-menu-item.tsx
Outdated
Show resolved
Hide resolved
eugenebelov
approved these changes
Dec 12, 2025
Member
davidatwhiletrue
left a comment
There was a problem hiding this comment.
I test changing the flex property on CSPR.live and the items disalign
https://github.com/user-attachments/assets/c5274ae3-206c-4f57-962c-47674804fef3
eugenebelov
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed paddingScale warning message in dev console. By make it transient props
Type of Change
Component(s) Affected
TooltipChanges Made
Replaced
paddingScalewith$paddingScaleto avoid adding it into DOM direcltyTesting
Storybook
Breaking Changes
Yes. We need to update all usages of Tooltip component
Screenshots/Videos
TODO
Checklist