This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Open
Conversation
|
This pull request has been linked to Shortcut Story #91360: Create Mulitplatform Extension for App Attestation: Flutter SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Creates
magic_ext/app_attestationfor our flutter packages.Although "code complete" this SHOULD NOT be merged until corresponding updates to Fortmatic BE are released.
** Note to Reviewers **
App Attestation utilizes Apple's Secure Enclave in the background to create the attestation object, as such, you will need to use an IRL device to test this PR. Check the notion doc for a breakdown on how to set that up. Thanks!
Related PR: [DO NOT MERGE] Integrate App Attestation into iOS SDK magic-ios#33
We'll add proper testing to the PR when the corresponding updates to Fortmatic BE are ready.