-
-
Notifications
You must be signed in to change notification settings - Fork 393
Add description on snapshot creation #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add description on snapshot creation #2786
Conversation
|
because this MR is quite long, I will try to explain a little bit about some change decisions and few concerns! storage_volume_snapshot shared/api/instance_snapshot.go instance_args I'd rather use snapshot as a nested struct of instance on every place like driver, api, db, etc, but this change is painful, so it's what it is! instance_snapshot_property I think that's all, let me know if have any question or improvements. |
|
I will check the pipeline errors and fix it! |
|
This PR implements #2254 |
8990ceb to
3ded45e
Compare
…ted column Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
…pshot parser Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
… refactoring Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
…apshot description Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
…shot description Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
…ot properties Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
3ded45e to
dcadbc7
Compare
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
Signed-off-by: Helder Ardachnikoff Gomes <helder.versatti@gmail.com>
No description provided.