fix(server): handle offline team reviewer sync gracefully#883
Merged
mertilginoglu merged 1 commit intostagingfrom Mar 7, 2026
Merged
fix(server): handle offline team reviewer sync gracefully#883mertilginoglu merged 1 commit intostagingfrom
mertilginoglu merged 1 commit intostagingfrom
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
2228643 to
8c6b993
Compare
8c6b993 to
aec3553
Compare
aec3553 to
6e4e617
Compare
6e4e617 to
62b7766
Compare
meryemefe
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issue #860 reports repeated server error logs when team reviewer expansion runs while the GitHub client is offline. These logs are noisy and misleading because offline mode can
be an expected runtime state.
Description
Updated pull request sync logic to treat offline reviewer-team expansion failures as expected behavior instead of hard errors.
Changes:
Testing Instructions
Prerequisites:
Flow:
./gradlew :application-server:test --tests de.tum.cit.aet.helios.pullrequest.github.GitHubPullRequestSyncServiceTest
./gradlew :application-server:test --tests de.tum.cit.aet.helios.branch.github.GitHubBranchComparisonServiceTest
Screenshots
No UI changes were made.
Checklist
General
Server