Make PinNotSet errors an interactive flow#181
Open
msirringhaus wants to merge 2 commits intolinux-credentials:masterfrom
Open
Make PinNotSet errors an interactive flow#181msirringhaus wants to merge 2 commits intolinux-credentials:masterfrom
msirringhaus wants to merge 2 commits intolinux-credentials:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add interactive possibility to 'fix'
PINNotSeterrors, same asPINRequired, to help with linux-credentials/credentialsd#135webauthn_{hid,nfc}examples now have a question whether it should use UV preferred or required, to be able to test both (PINNotSetobviously only is returned if UV is required)PinManagement-trait into and internal and public API, which is a bit hacky.change_pin()fromPinManagement, which can both change or set a PIN. Not super pretty, but should do in this case.This PR should probably stay open until I managed to fully integrated it into the credentialsd PR.