refactor(clippy): do not panic in production code paths#178
Merged
AlfioEmanueleFresta merged 9 commits intomasterfrom Mar 4, 2026
Merged
refactor(clippy): do not panic in production code paths#178AlfioEmanueleFresta merged 9 commits intomasterfrom
AlfioEmanueleFresta merged 9 commits intomasterfrom
Conversation
|
|
||
| impl fmt::Display for Channel { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result { | ||
| let card = self.card.lock().unwrap(); |
Member
Author
There was a problem hiding this comment.
The previous Display for pcsc Channel acquired the mutex and called
Card::status2() at display time, then collected CardStatus::reader_names().
Per the PC/SC spec, SCardStatus returns "the names by which the connected card reader is known"
- i.e. the same reader the handle was opened with via
Context::connect().
Since the reader name is fixed for the lifetime of the card handle, we now capture it fromInfo
at construction time, avoiding the mutex lock and potentialSCardStatusfailures inDisplay.
AlfioEmanueleFresta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unwrap,todo,expect,unreachablefrom non-test code pathsMakes the code a bit more verbose, but safer from (future) panics.