Fix migrationConfigs map not propagated during account update#3201
Merged
SophieGuo410 merged 2 commits intolinkedin:masterfrom Feb 19, 2026
Conversation
efcb836 to
14f2148
Compare
AccountInfoMap.addOrUpdateAccounts() was copying migrationConfig (singular) from the incoming account but not migrationConfigs (the fabric-specific map), causing updates to migrationConfigs to be silently dropped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add migrationConfigs (fabric-specific map) test counterparts for every existing migrationConfig test at the account level: - InMemoryAccountServiceTest: update and clear migrationConfigs - MySqlAccountServiceTest: create, update, delete, and legacy null assertion - MySqlAccountServiceIntegrationTest: end-to-end create/update/delete and adding migrationConfigs to an existing account Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
14f2148 to
75e91be
Compare
SophieGuo410
approved these changes
Feb 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3201 +/- ##
============================================
+ Coverage 64.24% 69.81% +5.56%
- Complexity 10398 12811 +2413
============================================
Files 840 930 +90
Lines 71755 79090 +7335
Branches 8611 9463 +852
============================================
+ Hits 46099 55214 +9115
+ Misses 23004 20926 -2078
- Partials 2652 2950 +298 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountInfoMap.addOrUpdateAccounts()was copyingmigrationConfig(singular) but notmigrationConfigs(the fabric-specific map) when merging an incoming account update with an existing account.migrationConfigsmap to be silently dropped since the builder retained the old account's value..migrationConfigs(account.getMigrationConfigs())call in the builder chain.Testing Done
migrationConfigstest counterparts for every existingmigrationConfigtest (account-level):InMemoryAccountServiceTestupdateAccountMigrationConfigsInMemoryAccountServiceTestupdateAccountClearMigrationConfigsMySqlAccountServiceTesttestAccountMigrationConfigsPersistenceMySqlAccountServiceTesttestLegacyAccountJsonDeserializationmigrationConfigsis null for legacy JSONMySqlAccountServiceIntegrationTesttestAccountMigrationConfigsIntegrationMySqlAccountServiceIntegrationTesttestAddMigrationConfigsToExistingAccount