Skip to content

Fix migrationConfigs map not propagated during account update#3201

Merged
SophieGuo410 merged 2 commits intolinkedin:masterfrom
nicolaslopezbravo:nicolaslopezbravo/fix-migrationconfigs-update-in-accountinfomap
Feb 19, 2026
Merged

Fix migrationConfigs map not propagated during account update#3201
SophieGuo410 merged 2 commits intolinkedin:masterfrom
nicolaslopezbravo:nicolaslopezbravo/fix-migrationconfigs-update-in-accountinfomap

Conversation

@nicolaslopezbravo
Copy link
Contributor

@nicolaslopezbravo nicolaslopezbravo commented Feb 19, 2026

Summary

  • AccountInfoMap.addOrUpdateAccounts() was copying migrationConfig (singular) but not migrationConfigs (the fabric-specific map) when merging an incoming account update with an existing account.
  • This caused updates to the migrationConfigs map to be silently dropped since the builder retained the old account's value.
  • Added the missing .migrationConfigs(account.getMigrationConfigs()) call in the builder chain.

Testing Done

  • Added migrationConfigs test counterparts for every existing migrationConfig test (account-level):
File Test Covers
InMemoryAccountServiceTest updateAccountMigrationConfigs Update: change map, verify new keys present and old keys removed
InMemoryAccountServiceTest updateAccountClearMigrationConfigs Delete: set to null, verify cleared
MySqlAccountServiceTest testAccountMigrationConfigsPersistence Create, update, and delete through MySQL mock path
MySqlAccountServiceTest testLegacyAccountJsonDeserialization Assert migrationConfigs is null for legacy JSON
MySqlAccountServiceIntegrationTest testAccountMigrationConfigsIntegration Create, update, and delete end-to-end
MySqlAccountServiceIntegrationTest testAddMigrationConfigsToExistingAccount Add migrationConfigs to account created without them
  • All unit tests pass. Integration tests compile successfully.

@nicolaslopezbravo nicolaslopezbravo force-pushed the nicolaslopezbravo/fix-migrationconfigs-update-in-accountinfomap branch from efcb836 to 14f2148 Compare February 19, 2026 21:20
nicolaslopezbravo and others added 2 commits February 19, 2026 13:24
AccountInfoMap.addOrUpdateAccounts() was copying migrationConfig (singular)
from the incoming account but not migrationConfigs (the fabric-specific map),
causing updates to migrationConfigs to be silently dropped.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add migrationConfigs (fabric-specific map) test counterparts for every
existing migrationConfig test at the account level:
- InMemoryAccountServiceTest: update and clear migrationConfigs
- MySqlAccountServiceTest: create, update, delete, and legacy null assertion
- MySqlAccountServiceIntegrationTest: end-to-end create/update/delete and
  adding migrationConfigs to an existing account

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nicolaslopezbravo nicolaslopezbravo force-pushed the nicolaslopezbravo/fix-migrationconfigs-update-in-accountinfomap branch from 14f2148 to 75e91be Compare February 19, 2026 21:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.81%. Comparing base (52ba813) to head (75e91be).
⚠️ Report is 345 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3201      +/-   ##
============================================
+ Coverage     64.24%   69.81%   +5.56%     
- Complexity    10398    12811    +2413     
============================================
  Files           840      930      +90     
  Lines         71755    79090    +7335     
  Branches       8611     9463     +852     
============================================
+ Hits          46099    55214    +9115     
+ Misses        23004    20926    -2078     
- Partials       2652     2950     +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SophieGuo410 SophieGuo410 merged commit 869d9e1 into linkedin:master Feb 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants