Skip to content

Fix generation of unwanted parquet file in doctest#468

Merged
hombit merged 1 commit intolincc-frameworks:mainfrom
OmBiradar:skip_doctest_creating_unwanted_parquet_file
Mar 5, 2026
Merged

Fix generation of unwanted parquet file in doctest#468
hombit merged 1 commit intolincc-frameworks:mainfrom
OmBiradar:skip_doctest_creating_unwanted_parquet_file

Conversation

@OmBiradar
Copy link
Contributor

Change Description

Closes #467

Solution Description

Adds # doctest: +SKIP to the function to_parquet of the NestedFrame class.

This doesn't affect the test itself, it just ignores the test and assumes that it works.

Code Quality

  • I have read the Contribution Guide and agree to the Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Signed-off-by: OmBiradar <ombiradar04@gmail.com>
@OmBiradar
Copy link
Contributor Author

See also #454 (comment)

@hombit hombit self-requested a review March 5, 2026 21:16
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hombit hombit merged commit 32a90df into lincc-frameworks:main Mar 5, 2026
10 checks passed
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (1f834d0) to head (78ee7ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          19       19           
  Lines        2156     2156           
=======================================
  Hits         2098     2098           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Before [1f834d0] After [0b2e261] Ratio Benchmark (Parameter)
560±200ms 582±200ms 1.04 benchmarks.ReadFewColumnsHTTPS.time_run
659±5ms 687±400ms 1.04 benchmarks.ReadFewColumnsS3.time_run
49.5±1ms 51.0±2ms 1.03 benchmarks.ReassignHalfOfNestedSeries.time_run
10.6±0.3ms 10.9±0.1ms 1.02 benchmarks.NestedFrameQuery.time_run
29.2±1ms 29.6±2ms 1.01 benchmarks.AssignSingleDfToNestedSeries.time_run
105M 105M 1 benchmarks.NestedFrameAddNested.peakmem_run
110M 110M 1 benchmarks.NestedFrameQuery.peakmem_run
109M 108M 1 benchmarks.NestedFrameReduce.peakmem_run
1.23±0.01ms 1.23±0.01ms 1 benchmarks.NestedFrameReduce.time_run
180M 180M 1 benchmarks.ReadFewColumnsHTTPS.peakmem_run

Click here to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unwanted parquet file generated during doc test

2 participants