Skip to content

Conversation

@ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Jan 21, 2026

Addresses #9944

@gemini-code-assist
Copy link

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on reducing the noise in the graph database logs by adjusting the logging level for specific messages. By downgrading certain 'not found' messages from warning to debug, the change ensures that the logs more accurately reflect the severity of events, making it easier to identify genuine issues while improving overall log readability.

Highlights

  • Logging Level Adjustment: Changed log.Warnf to log.Debugf for messages indicating a node or channel not being found in the graph cache within the UpdatePolicy function. This reclassifies these messages from warnings to debug information, as these conditions are not considered critical errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces log noise in the graph database cache by changing two log statements from Warnf to Debugf. This is a good change as these conditions might not be exceptional. I've added a couple of suggestions to align the new logging statements with the project's structured logging style guide, which will improve log observability and parsing.

@ziggie1984 ziggie1984 added logging Related to the logging / debug output functionality no-itest labels Jan 21, 2026
@ziggie1984 ziggie1984 marked this pull request as ready for review January 21, 2026 19:34
@ziggie1984 ziggie1984 self-assigned this Jan 21, 2026
@ziggie1984 ziggie1984 added the size/nano trivial move, refactor, renames label Jan 21, 2026
Copy link
Collaborator

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏆

A couple of proposals (optionally):

  • add release notes, since this is a known issue and people may look into the release notes to check for it
  • add comments in the code above the logging, explaining why this is Debug, not Info (I assume because this is expected and looks scary, so we don't want to spam with it in LND output)

@ziggie1984 ziggie1984 merged commit 8646d98 into lightningnetwork:master Jan 22, 2026
44 of 46 checks passed
@saubyk saubyk added this to the v0.20.1 milestone Jan 22, 2026
@saubyk saubyk added the backport-v0.20.x-branch This label is used to trigger the creation of a backport PR to the branch `v0.20.x-branch`. label Jan 22, 2026
@github-actions
Copy link

Successfully created backport PR for v0.20.x-branch:

ziggie1984 added a commit that referenced this pull request Jan 22, 2026
…20.x-branch

[v0.20.x-branch] Backport #10514: Reduce graphDB log noise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v0.20.x-branch This label is used to trigger the creation of a backport PR to the branch `v0.20.x-branch`. logging Related to the logging / debug output functionality no-changelog no-itest size/nano trivial move, refactor, renames

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants