-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Reduce graphDB log noise #10514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce graphDB log noise #10514
Conversation
Summary of ChangesHello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on reducing the noise in the graph database logs by adjusting the logging level for specific messages. By downgrading certain 'not found' messages from warning to debug, the change ensures that the logs more accurately reflect the severity of events, making it easier to identify genuine issues while improving overall log readability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reduces log noise in the graph database cache by changing two log statements from Warnf to Debugf. This is a good change as these conditions might not be exceptional. I've added a couple of suggestions to align the new logging statements with the project's structured logging style guide, which will improve log observability and parsing.
starius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏆
A couple of proposals (optionally):
- add release notes, since this is a known issue and people may look into the release notes to check for it
- add comments in the code above the logging, explaining why this is Debug, not Info (I assume because this is expected and looks scary, so we don't want to spam with it in LND output)
|
Successfully created backport PR for |
…20.x-branch [v0.20.x-branch] Backport #10514: Reduce graphDB log noise
Addresses #9944