Implement exponential backoff for texture loading retries#750
Draft
pecoram wants to merge 2 commits intolightning-js:v2from
Draft
Implement exponential backoff for texture loading retries#750pecoram wants to merge 2 commits intolightning-js:v2from
pecoram wants to merge 2 commits intolightning-js:v2from
Conversation
wouterlucas
reviewed
Mar 6, 2026
| this.txMemManager.frameTime = newFrameTime; | ||
|
|
||
| // Process texture retries with exponential backoff | ||
| this.txManager.processTextureRetries(); |
Contributor
There was a problem hiding this comment.
wouldnt it be better to make this part of processSome to put a time budget on it?
| */ | ||
| processTextureRetries(): void { | ||
| for (const texture of this.retryQueue) { | ||
| // load() will check canRetryNow() internally and only proceed if backoff has elapsed |
Contributor
There was a problem hiding this comment.
we should check for retry early on before calling load, else we're just wasting calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an exponential backoff strategy for texture loading retries to improve resource management and reduce immediate retry attempts after failures.